MTTL-376 Setup boiler plate code for logging the correlation ID #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evak6979
changed the title
evak6979
requested review from
MirelaGeorgiou,
LBHMKeyworth,
rashmishetty1011 and
LBHSPreston
as code owners
humulla
reviewed
Mar 15, 2021
| using Microsoft.AspNetCore.Routing; | ||
| using NUnit.Framework; | ||
|
|
||
| namespace BaseApi.Tests.V1.Controllers |
There was a problem hiding this comment.
The folder names need to be changed (both BaseAPI and BaseAPI.Tests)
There was a problem hiding this comment.
Happy to do so, but if possible we should merge the initial renaming PR. And then I can merge master from there to this branch which should resolve it.
There was a problem hiding this comment.
I forgot the renaming PR hasn't been merged, ignore this comment please
There was a problem hiding this comment.
No worries at all :) With 2 approvals, I took the liberty of merging the renaming PR to master and then into this branch. Renaming issues should be resolved by now.
mikemoody-amido
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
https://hackney.atlassian.net/browse/MTTL-376
Describe this PR
PR to add correlationId for every incoming request.
What is the problem we're trying to solve
CorrelationId will be used as part of our logging strategy. By including a CorrelationId with logs we will be able to trace individual requests during debugging/monitoring attempts.
What changes have we introduced
Checklist
Follow up actions after merging PR
Are there any next steps that need to addressed after merging this PR? Add them here.