Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child asset get #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Child asset get #118

wants to merge 2 commits into from

Conversation

sandipchandra
Copy link
Contributor

Link to JIRA ticket

https://hackney.atlassian.net/browse/HFS-220

Describe this PR

What is the problem we're trying to solve

From Elastic Search Asset Search endpoint there was no way to retrieve the child assets.

What changes have we introduced

Added new filter field parentAssetIds which is used to get all the child assets from the newly indexed Assets

Include any links to commits that introduce significant additions of code if they help explain the process of coming to the solution. e.g Addition of test database setup, addition of first test and production class, removal of buggy code, etc.

Checklist

  • [true ] Added end-to-end (i.e. integration) tests where necessary e.g to test complete functionality of a newly added feature
  • [true ] Added tests to cover all new production code
  • [true ] Added comments to the README or updated relevant documentation (add link to documentation), where necessary.
  • [true ] Checked all code for possible refactoring
  • [true ] Code pipeline builds correctly

Follow up actions after merging PR

Are there any next steps that need to addressed after merging this PR? Add them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant