MTTL 1117 #1
Open
MTTL 1117 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humulla
requested review from
notatiyyah,
amidomichael,
mikemoody-amido and
evak6979
| @@ -0,0 +1,21 @@ | |||
| using System.Threading.Tasks; | |||
|
|
|||
| namespace Hackney.Shared.ContactDetails.Sns | |||
There was a problem hiding this comment.
This needs to stay in a Sns folder in LBH-Core
| using System.Text.Json.Serialization; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Hackney.Shared.ContactDetails.Sns |
There was a problem hiding this comment.
Same with this - it lives in a Sns folder in LBH-Core
| @@ -0,0 +1,12 @@ | |||
| using System; | |||
|
|
|||
| namespace Hackney.Shared.ContactDetails | |||
There was a problem hiding this comment.
I think you might have created a console app instead of a class library?
|
|
||
| namespace Hackney.Shared.ContactDetails.Tests.Sns | ||
| { | ||
| public class SnsGatewayTests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the shared files for contact details have been added to this NuGet package