Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cloudwatch permission from task role #1999

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Tian-2017
Copy link
Collaborator

@Tian-2017 Tian-2017 commented Nov 27, 2024

I am removing it from task role. The execution role created in Wayne's ecs module includes two permission: read from ECR and read/write to cloudwatch permission. The python script in containers can write to CloudWatch ECS group via it.

And this will fix the error LimitExceeded: Cannot exceed quota for PolicySize: 6144
https://github.com/LBHackney-IT/Data-Platform/actions/runs/12029136720/job/33534177911

Copy link
Collaborator

@LBH-wgreeff LBH-wgreeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tian-2017 Tian-2017 merged commit 721130c into main Nov 27, 2024
12 checks passed
@Tian-2017 Tian-2017 deleted the remove-the-cloudwatch-permission-from-task-role branch November 27, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants