Dpf 220/ecs department roles #1979
Conversation
…ackney-IT/Data-Platform into dpf-220/ecs-department-roles
|
|
Sorry about the mess of commits on this one. Was going to tidy up but will just squash and merge to keep main reasonably sensible as it's actually not got that much going on. |
There was a problem hiding this comment.
Nice work! At first glance, I was wondering how it dynamically creates the role for each department without using for_each. Then I realised there’s a main department.tf file in the core folder, which makes sense.
Looks the ecs_department_policy miss the glue access, but feel free to merge, we can refine it later.
I figured they probably weren't needed because if you need an onward Glue job or crawler you'd likely be triggering that from Airflow. But yeah, if it turns out we need them it's easy enough to add another policy to do that. 👍 |
Creates base department roles for running ECS tasks that are broadly equivalent to the existing Glue roles.