Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move addresses api export bucket #1503

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Move addresses api export bucket #1503

merged 4 commits into from
Nov 13, 2023

Conversation

timburke-hackit
Copy link
Collaborator

Moves bucket resource out of the db_snapshot_to_s3 module and creates it as its own resource.

@timburke-hackit timburke-hackit marked this pull request as draft November 13, 2023 15:00
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@timburke-hackit timburke-hackit marked this pull request as ready for review November 13, 2023 15:48
LBH-wgreeff
LBH-wgreeff approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@LBH-wgreeff LBH-wgreeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timburke-hackit timburke-hackit merged commit 99bc16b into main Nov 13, 2023
6 checks passed
@timburke-hackit timburke-hackit deleted the move-addresses-api-export-bucket branch November 13, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LBH-wgreeff LBH-wgreeff LBH-wgreeff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timburke-hackit @LBH-wgreeff