Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dpp 558 liberator ingestion #1456

Merged
merged 17 commits into from
Oct 26, 2023
Merged

Dpp 558 liberator ingestion #1456

merged 17 commits into from
Oct 26, 2023

Conversation

timburke-hackit
Copy link
Collaborator

@timburke-hackit timburke-hackit commented Oct 16, 2023

Replaces much of the existing liberator ingestion process.

A new s3 bucket for storing exported snapshots from RDS. This replaces the existing bucket defined in modules/db-snapshot-to-s3.

2 new lambdas, python code for these has already been merged into main. These replace the old nodejs lambdas with behaviour that avoids the recursive SQS lambda invocation that motivated the overall rework.

2 eventbridge rules that:

  1. detect the completion of the RDS Snapshot creation which in turn invokes a lambda to start the RDS Snapshot export to s3
  2. detect the completion of the export process and invokes a lambda to move the export from the RDS export bucket to the raw zone

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@LBH-wgreeff LBH-wgreeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timburke-hackit timburke-hackit marked this pull request as ready for review October 17, 2023 13:54
@timburke-hackit timburke-hackit merged commit fd575ab into main Oct 26, 2023
11 checks passed
@timburke-hackit timburke-hackit deleted the dpp-558-liberator-ingestion branch October 26, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants