Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop prod key sharing #1435

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Stop prod key sharing #1435

merged 1 commit into from
Sep 13, 2023

Conversation

LBHTKarki
Copy link
Contributor

Key share is no longer necessary, so remove the config for it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@timburke-hackit
Copy link
Collaborator

@LBH-wgreeff I left this open for when you came back. Think Daro's done with the work that required this so, OK to merge this in?

@LBHTKarki LBHTKarki merged commit 40680d1 into main Sep 13, 2023
@LBHTKarki LBHTKarki deleted the remove-prod-key-sharing branch September 13, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timburke-hackit timburke-hackit timburke-hackit approved these changes

@LBH-wgreeff LBH-wgreeff Awaiting requested review from LBH-wgreeff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LBHTKarki @timburke-hackit