-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable initialisation and estimation of optional spatio-temperal coupling parameters to gaussian profile #307
Merged
MaxThevenet
merged 426 commits into
LASY-org:development
from
huixingjian:add_diag_util
Dec 19, 2024
Merged
Enable initialisation and estimation of optional spatio-temperal coupling parameters to gaussian profile #307
MaxThevenet
merged 426 commits into
LASY-org:development
from
huixingjian:add_diag_util
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huixingjian
force-pushed
the
add_diag_util
branch
from
October 16, 2024 09:08
0c6307f
to
498cf62
Compare
huixingjian
force-pushed
the
add_diag_util
branch
3 times, most recently
from
October 16, 2024 10:30
c218700
to
d2732b3
Compare
huixingjian
changed the title
[WIP] Enable initialisation of optional spatio-temperal coupling parameters to gaussian profile
Enable initialisation of optional spatio-temperal coupling parameters to gaussian profile
Oct 18, 2024
huixingjian
changed the title
Enable initialisation of optional spatio-temperal coupling parameters to gaussian profile
Enable initialisation and estimation of optional spatio-temperal coupling parameters to gaussian profile
Oct 18, 2024
huixingjian
changed the title
Enable initialisation and estimation of optional spatio-temperal coupling parameters to gaussian profile
[WIP]Enable initialisation and estimation of optional spatio-temperal coupling parameters to gaussian profile
Oct 28, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… into huixingjian/add_diag_util
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
MaxThevenet
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic! Just minor comments.
MaxThevenet
reviewed
Dec 19, 2024
MaxThevenet
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR, synergized with PR #182, introduces the initialization and estimation of first-order spatio-temporal coupling parameters in the
GaussianLongitudinalProfile
class. Four additional parameters have been added to the constructor:phi2
inzeta
inbeta
instc_theta
is the direction of transverse spatio-coupling in xoy planeIssue addressed
With the introduction of spatio-temporal coupling (STC), the
LongitudinalProfile
class can leverage additional information from the transverse profile. Along with the aforementioned parameters, the waist and focus length are also incorporated into the constructor. The transverse points x and y have been set to default values of 0 in the evaluate member function.In the laser utilities, a new function,$a = a_0 e^{i\theta}$ :
get_STC
, has been added to evaluate the STC parameters using the following formulas, with the laser envelope expressed asHere
phi2
refers to group-delay dispersionHere
stc_theta
mentioned above).with
Benefits
First order STC is enabled on both the initialisation and evaluation sides.
Test
The initialisation and the utils are tested through CI test
test_STC.py