Fix ViaFacet component type #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kezz
reviewed
Jun 15, 2022
platform-viaversion/src/main/java/net/kyori/adventure/platform/viaversion/ViaFacet.java
Outdated
Show resolved
Hide resolved
4 tasks
lucko
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct type when writing components as jsonelements instead of strings; this didn't cause any issue before because there were no handlers in Via trying to get the expected component type, but one has been added in 1.19 protocol transformation, causing an error when sending chat packets to 1.19+ clients.
The
majorVersionmethod on ViaAPI was added in 4.0.2 (a long while ago), now being checked to make sure this doesn't break on 5.x in case API changes a lot again.Unrelated to the issue, but this also uses
PacketWrapper.scheduleSendinstead ofsendto schedule this to the netty thread instead of any random thread this may be called on