Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameModifiersBehavior do not work in Beat Saber 1.27 #56

Closed
Kylon99 opened this issue Mar 8, 2023 · 0 comments · Fixed by #57
Closed

GameModifiersBehavior do not work in Beat Saber 1.27 #56

Kylon99 opened this issue Mar 8, 2023 · 0 comments · Fixed by #57
Assignees
@Kylon99
Labels
bug Something isn't working
Milestone
0.7.5

Comments

@Kylon99
Copy link
Owner

Kylon99 commented Mar 8, 2023

Looks like the code in GameModifiersBehavior.cs for

beatmapData.GetBeatmapDataItems<NoteData>()

has now changed to take an int subtypeGroupIdentifier parameter for getting special events and other things. The type it really wants for regular notes is just 0 (Event0).

Unfortunately we can't use the actual BasicBeatmapEventType enum that it is based on since the type is int. Beware of future changes where they fix this and break this again.
@Kylon99 Kylon99 added the bug Something isn't working label Mar 8, 2023
@Kylon99 Kylon99 added this to the 0.7.5 milestone Mar 8, 2023
@Kylon99 Kylon99 self-assigned this Mar 8, 2023
Kylon99 added a commit that referenced this issue Mar 8, 2023
@Kylon99
#56 Fixed GameModifiersBehavior to support Beat Saber 1.27. Updated t…
be9bec9 
…o 0.7.5
@Kylon99 Kylon99 mentioned this issue Mar 8, 2023
Merged
Kylon99 added a commit that referenced this issue Mar 8, 2023
@Kylon99
Merge pull request #57 from Kylon99/dev/master/#56_GameModifiersBehav…
d726c42 
…ior_do_not_work_in_Beat_Saber_1.27

#56 GameModifiersBehavior do not work in Beat Saber 1.27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kylon99 Kylon99

Labels
bug Something isn't working
Projects
None yet
Milestone
0.7.5
Development

Successfully merging a pull request may close this issue.

#56 GameModifiersBehavior do not work in Beat Saber 1.27 Kylon99/AlternativePlay
1 participant
@Kylon99