CSS Namespacing #49
Merged
CSS Namespacing #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,6 @@ build/Release | |||
| # Deployed apps should consider commenting this line out: | |||
| # see https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git | |||
| node_modules | |||
| dist | |||
There was a problem hiding this comment.
The compiled code shouldn't be committed to Github. I compile when creating a new release and push that to NPM. I think compiled code in Github is a bit icky as it creates weird diffs plus is hard to remember to keep updated plus isn't that useful anyways since you only need the compiled version when installing.
There was a problem hiding this comment.
@KyleAMathews I agree; that was leftover from the original PR. I didn't alter it on the off chance that I was missing something but since you've confirmed the compiled code shouldn't be there, I'll update the PR.
|
Published a 2.0! Thanks @kkozee and @carlos-stored! |
This was referenced Jan 25, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KyleAMathews