Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only support kcl schema type in the AppConfig generator #496

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

only support kcl schema type in the AppConfig generator to avoid unnecessary diffs

Which issue(s) this PR fixes:

Fixes #489

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


Copy link
Contributor

@panshuai111 panshuai111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit a3fd2f9 into KusionStack:main Aug 28, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: illegal field _type appears in the preview result
2 participants