Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Prometheus support #490

Merged
merged 2 commits into from
Aug 31, 2023
Merged

feat: add Prometheus support #490

merged 2 commits into from
Aug 31, 2023

Conversation

ffforest
Copy link
Contributor

@ffforest ffforest commented Aug 23, 2023 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., design docs, usage docs, etc.:

Design doc: https://github.com/KusionStack/kusion/blob/main/docs/prometheus.md

@ffforest ffforest added this to the 0.9.0 milestone Aug 23, 2023
@coveralls
Copy link

coveralls commented Aug 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6024156146

  • 115 of 127 (90.55%) changed or added relevant lines in 4 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 74.782%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/appconfiguration/generator/workload/service_generator.go 24 25 96.0%
pkg/generator/appconfiguration/generator/monitoring_generator.go 82 93 88.17%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/engine/operation/parser/parser.go 3 75.61%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
Totals Coverage Status
Change from base Build 6022361818: 0.1%
Covered Lines: 6162
Relevant Lines: 8240
💛 - Coveralls

@ffforest ffforest force-pushed the feat-add-prometheus-support branch 2 times, most recently from c8fbaba to 0aad251 Compare August 29, 2023 08:44
@ffforest ffforest force-pushed the feat-add-prometheus-support branch 3 times, most recently from 0914107 to d0e9a87 Compare August 30, 2023 08:02
adohe
adohe approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe merged commit 2ce275f into KusionStack:main Aug 31, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
@ffforest ffforest linked an issue Sep 1, 2023 that may be closed by this pull request
Model: AppConfiguration model supports monitoring capability backed by Prometheus #444
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan left review comments

@adohe adohe adohe approved these changes

@elliotxx elliotxx Awaiting requested review from elliotxx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Model: AppConfiguration model supports monitoring capability backed by Prometheus
4 participants
@ffforest @coveralls @SparkYuan @adohe