Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add probe types and encoding/decoding support #487

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Aug 23, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

add probe types and encoding/decoding support

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the area/cli label Aug 23, 2023
@adohe adohe added this to the 0.9.0 milestone Aug 23, 2023
@adohe adohe self-assigned this Aug 23, 2023
@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Aug 23, 2023
@coveralls
Copy link

coveralls commented Aug 23, 2023

Pull Request Test Coverage Report for Build 5946800497

  • 90 of 101 (89.11%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 73.899%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/models/appconfiguration/workload/container/container.go 90 101 89.11%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/engine/operation/parser/parser.go 6 74.36%
Totals Coverage Status
Change from base Build 5936745806: 0.1%
Covered Lines: 5691
Relevant Lines: 7701

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit fef7d23 into KusionStack:main Aug 23, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@adohe adohe deleted the add_probe_types branch January 8, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants