Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support unmarshal KCL union to AppConfiguration #462

Merged
merged 1 commit into from
Aug 18, 2023
Merged

feat: support unmarshal KCL union to AppConfiguration #462

merged 1 commit into from
Aug 18, 2023

Conversation

panshuai111
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support unmarshal KCL union to AppConfiguration

Which issue(s) this PR fixes:

Fixes #

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5898591895

  • 4 of 7 (57.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 71.916%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/appconfiguration/generator/app_configurations_generator.go 0 1 0.0%
pkg/generator/kcl/kcl_generator.go 4 6 66.67%
Totals Coverage Status
Change from base Build 5888275489: 0.04%
Covered Lines: 5211
Relevant Lines: 7246
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 5003a4a into KusionStack:main Aug 18, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panshuai111 @coveralls @SparkYuan