Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: customize workload deserialization and serialization by type #456

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat: customize workload deserialization and serialization by type #456

merged 1 commit into from
Aug 16, 2023

Conversation

elliotxx
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Customize workload deserialization and serialization by type

@elliotxx elliotxx self-assigned this Aug 16, 2023
@elliotxx elliotxx added this to the 0.9.0 milestone Aug 16, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5874428118

  • 23 of 39 (58.97%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 69.901%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/models/appconfiguration/workload/workload.go 23 39 58.97%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 78.21%
pkg/cmd/apply/options.go 7 71.92%
Totals Coverage Status
Change from base Build 5863402356: -0.07%
Covered Lines: 5202
Relevant Lines: 7442
💛 - Coveralls

@elliotxx elliotxx enabled auto-merge (squash) August 16, 2023 04:09
adohe
adohe approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elliotxx elliotxx merged commit 5e23a2f into KusionStack:main Aug 16, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2023
@elliotxx elliotxx linked an issue Aug 21, 2023 that may be closed by this pull request
Feature: Customize workload deserialization and serialization by type #471
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adohe adohe adohe approved these changes

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

@ffforest ffforest Awaiting requested review from ffforest

@panshuai111 panshuai111 Awaiting requested review from panshuai111

@healthjyk healthjyk Awaiting requested review from healthjyk

@liu-hm19 liu-hm19 Awaiting requested review from liu-hm19

Assignees

@elliotxx elliotxx

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Feature: Customize workload deserialization and serialization by type
3 participants
@elliotxx @coveralls @adohe