Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add design documentation for Prometheus support in kusion #412

Merged
merged 1 commit into from
Aug 9, 2023
Merged

doc: Add design documentation for Prometheus support in kusion #412

merged 1 commit into from
Aug 9, 2023

Conversation

ffforest
Copy link
Contributor

@ffforest ffforest commented Jul 26, 2023 •
edited
Loading

Design doc for kusion's Prometheus support mentioned in #383

@ffforest ffforest added kind/documentation Improvements or additions to documentation kind/enhancement labels Jul 26, 2023
@ffforest ffforest added this to the 0.9.0 milestone Jul 26, 2023
@ffforest ffforest self-assigned this Jul 26, 2023
@ffforest ffforest linked an issue Jul 26, 2023 that may be closed by this pull request
Model: Design documentation for Prometheus support in AppConfiguration model #383
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5665960742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 72.55%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/engine/operation/parser/parser.go 3 78.21%
Totals Coverage Status
Change from base Build 5655359990: 0.07%
Covered Lines: 5109
Relevant Lines: 7042
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit c98fb1d into KusionStack:main Aug 9, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@elliotxx elliotxx Awaiting requested review from elliotxx

@adohe adohe Awaiting requested review from adohe

Assignees

@ffforest ffforest

Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Model: Design documentation for Prometheus support in AppConfiguration model
3 participants
@ffforest @coveralls @SparkYuan