Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more details when runtime init failed #409

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

add more details when runtime init failed

Which issue(s) this PR fixes:

Fixes #361

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 5657143478

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 72.55%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/engine/operation/parser/parser.go 3 78.21%
Totals Coverage Status
Change from base Build 5655359990: 0.07%
Covered Lines: 5109
Relevant Lines: 7042

💛 - Coveralls

Copy link
Contributor

@panshuai111 panshuai111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panshuai111 panshuai111 merged commit ffed2da into KusionStack:main Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: No specific cause of the error printed when the init the k8s runtime failed.
3 participants