Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add design documentation for Istio support in kusion #399

Merged
merged 1 commit into from
Jul 25, 2023
Merged

doc: Add design documentation for Istio support in kusion #399

merged 1 commit into from
Jul 25, 2023

Conversation

ffforest
Copy link
Contributor

Design doc for kusion's Istio support mentioned in #382

@ffforest ffforest added kind/documentation Improvements or additions to documentation kind/enhancement labels Jul 21, 2023
@ffforest ffforest added this to the 0.9.0 milestone Jul 21, 2023
@ffforest ffforest self-assigned this Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ffforest ffforest linked an issue Jul 21, 2023 that may be closed by this pull request
Model: Design documentation for Istio support in AppConfiguration model #382
Closed
@coveralls
Copy link

coveralls commented Jul 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5619383667

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 72.902%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 78.21%
Totals Coverage Status
Change from base Build 5599705927: -0.01%
Covered Lines: 5055
Relevant Lines: 6934
💛 - Coveralls

@ffforest
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

SparkYuan
SparkYuan approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, it looks good to me. Please add a use case about how to configure Istio rules in the AppConfig model in the latter version.

@SparkYuan SparkYuan merged commit ce8a47d into KusionStack:main Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@elliotxx elliotxx Awaiting requested review from elliotxx

@adohe adohe Awaiting requested review from adohe

Assignees

@ffforest ffforest

Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Model: Design documentation for Istio support in AppConfiguration model
3 participants
@ffforest @coveralls @SparkYuan