Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the latter volume dirs overwrite the prior one #1214

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: the latter volume dirs overwrite the prior one #1214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/modules/generators/workload/workload_generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ func toOrderedContainers(

// Create a slice of volumes and configMaps based on the containers' files to be created.
var volumes []corev1.Volume
var volumeMounts []corev1.VolumeMount
var configMaps []corev1.ConfigMap

if err := modules.ForeachOrdered(appContainers, func(containerName string, c v1.Container) error {
Expand Down Expand Up @@ -128,10 +127,12 @@ func toOrderedContainers(
}

// Append the configMap, volume and volumeMount objects into the corresponding slices.
volumes, volumeMounts, configMaps, err = handleFileCreation(c, uniqueAppName, containerName)
volumesContainer, volumeMounts, configMapsContainer, err := handleFileCreation(c, uniqueAppName, containerName)
if err != nil {
return err
}
volumes = append(volumes, volumesContainer...)
configMaps = append(configMaps, configMapsContainer...)
ctn.VolumeMounts = append(ctn.VolumeMounts, volumeMounts...)

// Append more volumes and volumeMounts
Expand Down
Loading