Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: operationDelaySeconds for update endless reconcile #296

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

ColdsteelRail
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.28%. Comparing base (1384acc) to head (8db9740).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   66.16%   66.28%   +0.12%     
==========================================
  Files          78       78              
  Lines        5665     5665              
==========================================
+ Hits         3748     3755       +7     
+ Misses       1557     1552       -5     
+ Partials      360      358       -2     
Flag Coverage Δ
unittests 66.28% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColdsteelRail ColdsteelRail changed the title bugfix: GetPodUpdateFinishStatus bugfix: operationDelaySeconds for update endless reconcile Oct 14, 2024
@ColdsteelRail
Copy link
Member Author

问题:原地升级时使用 operationDelaySeconds 陷入无限调和
修复:等待 operationDelaySeconds 过程中,过早判定升级结束,需等待 LastPodStatusAnnotationKey 达到预期才判定结束

@ColdsteelRail ColdsteelRail merged commit c9d5936 into main Nov 11, 2024
11 of 12 checks passed
@ColdsteelRail ColdsteelRail deleted the fix-GetPodUpdateFinishStatus branch November 11, 2024 06:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
@ColdsteelRail
Copy link
Member Author

#301

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
2 participants