Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove label service-available when pod is not ready #281

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

shaofan-hs
Copy link
Collaborator

@shaofan-hs shaofan-hs commented Sep 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #283

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@shaofan-hs shaofan-hs force-pushed the fix-service-available branch 7 times, most recently from fa31df5 to 08484aa Compare September 22, 2024 05:42
@shaofan-hs shaofan-hs force-pushed the fix-service-available branch from 08484aa to e9ba4cd Compare September 22, 2024 05:45
Copy link
Member

@ColdsteelRail ColdsteelRail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaofan-hs shaofan-hs merged commit 1c69095 into KusionStack:main Sep 23, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Pod is service-available when pod becomes not ready. 提供灰度流量的能力
2 participants