-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CollaSet supports exclude and include pod #258
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 66.06% 66.21% +0.15%
==========================================
Files 78 79 +1
Lines 5681 5739 +58
==========================================
+ Hits 3753 3800 +47
- Misses 1574 1579 +5
- Partials 354 360 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e8d6668
to
6ec53e6
Compare
31517aa
to
b180311
Compare
71c5f8b
to
ec0b9ef
Compare
ec0b9ef
to
94f7eef
Compare
94f7eef
to
d76929f
Compare
4aac508
to
b21a281
Compare
b21a281
to
7bfd0ab
Compare
lgtm, cc @zoumo |
c5229eb
to
23cf697
Compare
2a09e6b
to
e08e459
Compare
pkg/webhook/server/generic/collaset/collaset_validating_handler.go
Outdated
Show resolved
Hide resolved
pkg/webhook/server/generic/collaset/collaset_validating_handler.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references:
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.