Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize the events about pods #173

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

shaofan-hs
Copy link
Collaborator

@shaofan-hs shaofan-hs commented Mar 26, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

re #172

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 65.51%. Comparing base (4544135) to head (6dc1450).
Report is 3 commits behind head on main.

Files Patch % Lines
...lers/podopslifecycle/podopslifecycle_controller.go 80.00% 0 Missing and 2 partials ⚠️
.../controllers/poddeletion/poddeletion_controller.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   65.11%   65.51%   +0.40%     
==========================================
  Files          74       74              
  Lines        4810     4817       +7     
==========================================
+ Hits         3132     3156      +24     
+ Misses       1397     1375      -22     
- Partials      281      286       +5     
Flag Coverage Δ
unittests 65.51% <76.92%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaofan-hs shaofan-hs force-pushed the event branch 2 times, most recently from ae49fab to 383257f Compare March 26, 2024 12:56
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 9f93834 into KusionStack:main Mar 28, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
2 participants