Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: podopslifecycle webhook waits for more events #171

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

shaofan-hs
Copy link
Collaborator

@shaofan-hs shaofan-hs commented Mar 25, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references:

  • N
  • Y

fix #170

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@shaofan-hs shaofan-hs force-pushed the issue170 branch 2 times, most recently from d11e808 to 818f48b Compare March 25, 2024 12:08
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.13%. Comparing base (72fb78d) to head (7f9845d).
Report is 1 commits behind head on main.

Files Patch % Lines
...webhook/server/generic/pod/opslifecycle/webhook.go 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   64.01%   65.13%   +1.11%     
==========================================
  Files          73       74       +1     
  Lines        4708     4810     +102     
==========================================
+ Hits         3014     3133     +119     
+ Misses       1419     1396      -23     
- Partials      275      281       +6     
Flag Coverage Δ
unittests 65.13% <94.87%> (+1.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaofan-hs shaofan-hs force-pushed the issue170 branch 8 times, most recently from bbcb429 to e309f0a Compare March 26, 2024 07:05
Copy link
Collaborator

@Eikykun Eikykun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shaofan-hs shaofan-hs merged commit 4544135 into KusionStack:main Mar 26, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: PodOpsLifecycle do not continue and waits for more events
2 participants