-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor podUpdater interface #166
Conversation
2. fix bug: replace pod by to-replace label, not check new pod status when pod upgrade policy is not replace update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 65.66% 63.99% -1.67%
==========================================
Files 74 73 -1
Lines 4817 4711 -106
==========================================
- Hits 3163 3015 -148
- Misses 1370 1419 +49
+ Partials 284 277 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@wu8685 code modified by the cr comments,please review again~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Shouldn't we return |
…eUpdate GetPodUpdateFinishStatus when replace new pair pod is not exist
yes, I'll change this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1. Does this PR affect any open issues?(Y/N) and add issue references
fix #182
2. What is the scope of this PR (e.g. component or file name):
collaset_controller reconcile:
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.