Add new pod lifecycle phase (#299)

* add pod label to indicate PodOpsLifecycle phase * add UT * add creating label when replacing pod created * add UT
KusionStack · Oct 29, 2024 · e4e981f · e4e981f
1 parent a91ffd8
commit e4e981f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/pkg/controllers/collaset/collaset_controller_test.go b/pkg/controllers/collaset/collaset_controller_test.go
@@ -130,6 +130,19 @@ var _ = Describe("collaset controller", func() {
 				return expectedStatusReplicas(c, cs, 0, 0, 0, 2, 2, 0, 0, 0)
 			}, 5*time.Second, 1*time.Second).Should(BeNil())
 
+			Eventually(func() bool {
+				Expect(c.List(context.TODO(), podList, client.InNamespace(cs.Namespace))).Should(BeNil())
+				return len(podList.Items) == 2
+			}, 5*time.Second, 1*time.Second).Should(BeTrue())
+
+			for _, pod := range podList.Items {
+				if pod.Name == originPodName {
+					continue
+				}
+
+				Expect(pod.Labels[appsv1alpha1.PodCreatingLabel]).ShouldNot(BeEquivalentTo(""))
+			}
+
 			// update collaset with recreate update
 			observedGeneration := cs.Status.ObservedGeneration
 			Expect(updateCollaSetWithRetry(c, cs.Namespace, cs.Name, func(cls *appsv1alpha1.CollaSet) bool {

diff --git a/pkg/controllers/collaset/synccontrol/replace.go b/pkg/controllers/collaset/synccontrol/replace.go
@@ -154,6 +154,7 @@ func (r *RealSyncControl) replaceOriginPods(
 			ownedIDs[newPodId].Remove(podcontext.JustCreateContextDataKey)
 		}
 		newPod.Labels[appsv1alpha1.PodReplacePairOriginName] = originPod.GetName()
+		newPod.Labels[appsv1alpha1.PodCreatingLabel] = strconv.FormatInt(time.Now().UnixNano(), 10)
 		newPodContext.Put(podcontext.RevisionContextDataKey, replaceRevision.Name)
 		// create pvcs for new pod
 		err = r.pvcControl.CreatePodPvcs(ctx, instance, newPod, resources.ExistingPvcs)