feat: Automatically calculate the current version number through Git…

[rajeshkio]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Automates versioning and updates pkg/version/VERSION file

Which issue(s) this PR fixes:

Fixes #537

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[rajeshkio]

I have read the CLA Document and I hereby sign the CLA

[rajeshkio]

recheck

[SparkYuan]

@rajeshkio Welcome to join our community. Here is our slack

[elliotxx]

@rajeshkio Nice! It seems to be able to automatically calculate the current version number, but, the make command still needs to be manually executed before each release. So I am thinking about how to integrate it in the release pipeline. Maybe we need to add a hook to the .goreleaser.yml. Do you have any good ideas?

[rajeshkio]

sure. Let me see. I thought it will do the make call internally.

[elliotxx]

@rajeshkio You can refer to this configuration: https://github.com/elliotxx/go-web-template/blob/master/.goreleaser.yml#L7

But this can only ensure that the version in the Image is correct and cannot guarantee that go install can get the correct version number.

[rajeshkio]

make sense to hook it just after go mod tidy?

before:
hooks:
# You may remove this if you don't use go modules.
- go mod tidy
- go run pkg/version/scripts/gen/gen.go

[rajeshkio]

@rajeshkio You can refer to this configuration: https://github.com/elliotxx/go-web-template/blob/master/.goreleaser.yml#L7

But this can only ensure that the version in the Image is correct and cannot guarantee that go install can get the correct version number.

This is interesting. Something I have never experienced. Can I test it locally?

[elliotxx]

@rajeshkio You can refer to this configuration: https://github.com/elliotxx/go-web-template/blob/master/.goreleaser.yml#L7
But this can only ensure that the version in the Image is correct and cannot guarantee that go install can get the correct version number.

This is interesting. Something I have never experienced. Can I test it locally?

Of course, this is some ways to test this case locally:

• Dry Run Mode for Goreleaser: https://goreleaser.com/quick-start/#dry-run
• go install github.com/rajeshkio/karpor/cmd@automatically-calculate-current-version

You can compare the different version numbers they generate.

[elliotxx]

make sense to hook it just after go mod tidy?

before: hooks: # You may remove this if you don't use go modules. - go mod tidy - go run pkg/version/scripts/gen/gen.go

Yes, this hook ensures that the gen script is executed to update the version number before the go build.

[elliotxx]

Maybe we don't need to consider go install for the time being. This is just considered for the future Standalone installation mode (such as homebrew, scoop, go install). #240

[rajeshkio]

Maybe we do n’t need to consider go install for the time being. This is just considered for the future Standalone installation mode (such as homebrew, scoop, go install).

okay. Your decision. I am not well aware of this. If it can be ignored for now, we can create another issue for this, assigned to me, and I can work on it separately.

[rajeshkio]

make sense to hook it just after go mod tidy?
before: hooks: # You may remove this if you don't use go modules. - go mod tidy - go run pkg/version/scripts/gen/gen.go

Yes, this hook ensures that the gen script is executed to update the version number before the go build.

added.

[rajeshkio]

@elliotxx Let me know if anything is pending from my side

[elliotxx]

@rajeshkio You have done a good job, I just have no time to do full test. But I thought about it, this it doesn't matter. We are the trunk-based development mode, there will be a full test before the official version is released.

[elliotxx]

lgtm

[elliotxx]

@rajeshkio Welcome to become a project contributor! #552 Looking forward to more communication between us 🍻