Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show VersionNumber in dashboard #531

Merged
merged 2 commits into from
Jul 13, 2024
Merged

feat: show VersionNumber in dashboard #531

merged 2 commits into from
Jul 13, 2024

Conversation

solarhell
Copy link
Contributor

Ref: #362

Preview:

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@solarhell solarhell mentioned this pull request Jul 12, 2024
Closed
@solarhell
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@elliotxx
Copy link
Collaborator

@solarhell Hello, I found that the License Check failed because the VERSION file was checked incorrectly. Can you add pkg/version/VERSION to the paths-ignore in .licenserc.yaml?

image

image

@solarhell
Copy link
Contributor Author

@elliotxx Added, please check.

elliotxx
elliotxx approved these changes Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 05839e0 into KusionStack:main Jul 13, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2024
@elliotxx elliotxx added this to the v0.5.0 milestone Jul 17, 2024
@elliotxx elliotxx added the area/experience Experience related optimization label Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@panshuai111 panshuai111 Awaiting requested review from panshuai111 panshuai111 is a code owner

@adohe adohe Awaiting requested review from adohe adohe is a code owner

@ffforest ffforest Awaiting requested review from ffforest ffforest is a code owner

@ruquanzhao ruquanzhao Awaiting requested review from ruquanzhao ruquanzhao is a code owner

Assignees
No one assigned
Labels
area/experience Experience related optimization
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@solarhell @elliotxx