Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search data from search storage layer #32

Merged
merged 2 commits into from
May 9, 2023

Conversation

panshuai111
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

search data from search storage layer

@panshuai111 panshuai111 requested review from elliotxx and adohe as code owners May 6, 2023 03:00
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 185 files.

Valid Invalid Ignored Fixed
141 3 41 0
Click to see the invalid file list
  • cmd/app/options/search_storage.go
  • pkg/search/storage/elasticsearch/factory.go
  • pkg/search/storage/elasticsearch/parse.go

cmd/app/options/search_storage.go Show resolved Hide resolved
pkg/search/storage/elasticsearch/factory.go Show resolved Hide resolved
pkg/search/storage/elasticsearch/parse.go Show resolved Hide resolved
Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit abc6aad into main May 9, 2023
@elliotxx elliotxx deleted the search-data-from-storage-layer branch May 9, 2023 08:34
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2023
@elliotxx elliotxx added enhancement New feature or request area/server Server related. labels May 9, 2023
@elliotxx elliotxx added this to the v0.2.0 milestone May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/server Server related. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Provide a search API for retrieving multi-cluster resources from storage
2 participants