Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update container env validation rule #6

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Aug 4, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix container env validation rule issue

Which issue(s) this PR fixes:

Fixes #5

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe requested a review from elliotxx as a code owner August 4, 2023 06:26
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@adohe adohe self-assigned this Aug 4, 2023
@adohe
Copy link
Contributor Author

adohe commented Aug 4, 2023

I have read the CLA Document and I hereby sign the CLA

@elliotxx elliotxx enabled auto-merge (squash) August 4, 2023 06:33
Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 219cfb0 into main Aug 4, 2023
6 of 7 checks passed
@elliotxx elliotxx deleted the fix_env_validation_rule branch August 4, 2023 06:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container env validation rule use not defined variable
2 participants