Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate Component base model and rename LongRunningServic… #12

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Aug 11, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Refact base models to reflect our latest thinking, deprecate old Component model and rename LongRunningService to Service.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe requested a review from elliotxx as a code owner August 11, 2023 03:39
@adohe adohe self-assigned this Aug 11, 2023
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adohe adohe merged commit c5435e7 into main Aug 11, 2023
5 checks passed
@adohe adohe deleted the update_base_model branch August 11, 2023 05:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants