Squashing client and worker shutdown errors #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the worker is not cleanly shutdown, a log entry is created and the exception is squashed. This ensures we don't unnecessarily crash systems that are already in the process of shutting down.
|
Actually...the shutdown isn't necessary at all. Temporal already listens for shutdown signals: https://typescript.temporal.io/api/interfaces/worker.RuntimeOptions#shutdownsignals. |
|
I'm also seeing a client shutdown error during testing: nestjs-temporal/lib/utils/client.util.ts Lines 4 to 7 in 4d8a948 |
|
Confirmed that client close is the source of my problems. This fixes them. |
clintonb
force-pushed
the
clintonb/fix-shutdown
branch
from
c4f7168 to
35076bb
Compare
clintonb
changed the title
|
@KurtzL is there a timeline for reviewing and merging? |
KurtzL
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client connection or worker is not cleanly shutdown, a log entry is created and the exception is squashed. This ensures we don't unnecessarily crash systems that are already in the process of shutting down.
Fixes #38