Don't register Coinjoin Coordinator when it's not set up (WalletWasab…

…i#13383)

WalletWasabi.Daemon/Global.cs

@@ -206,6 +206,10 @@ public Global(string dataDir, string configFilePath, Config config)
 	private AllTransactionStore AllTransactionStore { get; }
 	private IndexStore IndexStore { get; }
 
+	private bool HasCoordinatorConfigured => Config.GetCoordinatorUri() is { } coordinatorUri &&
+												coordinatorUri.AbsoluteUri != "https://api.wasabiwallet.io/" &&
+												coordinatorUri.AbsoluteUri != "https://api.wasabiwallet.co/";
+
 	private WasabiHttpClientFactory BuildHttpClientFactory(Func<Uri> backendUriGetter) =>
 		new(
 			Config.UseTor != TorMode.Disabled ? TorSettings.SocksEndpoint : null,
@@ -256,11 +260,14 @@ public async Task InitializeNoWalletAsync(bool initializeSleepInhibitor, Termina
 
 				await BlockDownloadService.StartAsync(cancel).ConfigureAwait(false);
 
-				RegisterCoinJoinComponents();
-
-				if (initializeSleepInhibitor)
+				if (HasCoordinatorConfigured)
 				{
-					await CreateSleepInhibitorAsync().ConfigureAwait(false);
+					RegisterCoinJoinComponents();
+
+					if (initializeSleepInhibitor)
+					{
+						await CreateSleepInhibitorAsync().ConfigureAwait(false);
+					}
 				}
 
 				bool useTestApi = Network != Network.Main;

WalletWasabi.Fluent/Models/Wallets/CoinListModel.cs

@@ -22,7 +22,7 @@ public CoinListModel(Wallet wallet, IWalletModel walletModel)
 		WalletModel = walletModel;
 		var transactionProcessed = walletModel.Transactions.TransactionProcessed;
 		var anonScoreTargetChanged = this.WhenAnyValue(x => x.WalletModel.Settings.AnonScoreTarget).Skip(1).ToSignal();
-		var isCoinjoinRunningChanged = walletModel.Coinjoin.IsRunning.ToSignal();
+		var isCoinjoinRunningChanged = walletModel.IsCoinjoinRunning.ToSignal();
 		var isSelected = this.WhenAnyValue(x => x.WalletModel.IsSelected).Skip(1).ToSignal();
 
 		var signals =

WalletWasabi.Fluent/Models/Wallets/HardwareWalletModel.cs

@@ -4,6 +4,7 @@
 using WalletWasabi.Wallets;
 using WalletWasabi.Extensions;
 using WalletWasabi.Logging;
+using WalletWasabi.WabiSabi.Client;
 
 namespace WalletWasabi.Fluent.Models.Wallets;
 
@@ -22,13 +23,13 @@ public async Task<bool> AuthorizeTransactionAsync(TransactionAuthorizationInfo t
 		try
 		{
 			var client = new HwiClient(Wallet.Network);
-			
+
 			TimeSpan baseTimeout = TimeSpan.FromMinutes(3);
 
 			// Define the additional timeout increment as a TimeSpan for every 10 inputs.
 			TimeSpan additionalTimeoutPer10Inputs = TimeSpan.FromMinutes(1);
 			int inputCount = transactionAuthorizationInfo.Transaction.WalletInputs.Count;
-			
+
 			TimeSpan totalTimeout = baseTimeout + TimeSpan.FromMinutes((inputCount / 10) * additionalTimeoutPer10Inputs.TotalMinutes);
 			using var cts = new CancellationTokenSource(totalTimeout);
 

WalletWasabi.Fluent/Models/Wallets/WalletCoinjoinModel.cs

@@ -18,21 +18,24 @@ public partial class WalletCoinjoinModel : ReactiveObject
 {
 	private readonly Wallet _wallet;
 	private readonly IWalletSettingsModel _settings;
-	private CoinJoinManager _coinJoinManager;
+	private CoinJoinManager? _coinJoinManager;
 	[AutoNotify] private bool _isCoinjoining;
 
-	public WalletCoinjoinModel(Wallet wallet, IWalletSettingsModel settings)
+	public WalletCoinjoinModel(Wallet wallet, CoinJoinManager? coinjoinManager, IWalletSettingsModel settings)
 	{
 		_wallet = wallet;
 		_settings = settings;
-		_coinJoinManager = Services.HostedServices.Get<CoinJoinManager>();
-
-		StatusUpdated =
-			Observable.FromEventPattern<StatusChangedEventArgs>(_coinJoinManager, nameof(CoinJoinManager.StatusChanged))
-					  .Where(x => x.EventArgs.Wallet == wallet)
-					  .Select(x => x.EventArgs)
-					  .Where(x => x is WalletStartedCoinJoinEventArgs or WalletStoppedCoinJoinEventArgs or StartErrorEventArgs or CoinJoinStatusEventArgs or CompletedEventArgs or StartedEventArgs)
-					  .ObserveOn(RxApp.MainThreadScheduler);
+		_coinJoinManager = coinjoinManager;
+
+		StatusUpdated = _coinJoinManager is { }
+			? Observable
+				.FromEventPattern<StatusChangedEventArgs>(_coinJoinManager, nameof(CoinJoinManager.StatusChanged))
+				.Where(x => x.EventArgs.Wallet == wallet)
+				.Select(x => x.EventArgs)
+				.Where(x => x is WalletStartedCoinJoinEventArgs or WalletStoppedCoinJoinEventArgs or StartErrorEventArgs
+					or CoinJoinStatusEventArgs or CompletedEventArgs or StartedEventArgs)
+				.ObserveOn(RxApp.MainThreadScheduler)
+			: Observable.Return(new StatusChangedEventArgs(wallet));
 
 		settings.WhenAnyValue(x => x.AutoCoinjoin)
 				.Skip(1) // The first one is triggered at the creation.

WalletWasabi.Fluent/Models/Wallets/WalletModel.cs

@@ -1,4 +1,3 @@
-using System.Collections;
 using System.Collections.Generic;
 using System.ComponentModel;
 using System.Reactive.Linq;
@@ -8,6 +7,7 @@
 using WalletWasabi.Fluent.Infrastructure;
 using WalletWasabi.Fluent.Models.Transactions;
 using WalletWasabi.Fluent.ViewModels.Wallets.Labels;
+using WalletWasabi.WabiSabi.Client;
 using WalletWasabi.Wallets;
 
 namespace WalletWasabi.Fluent.Models.Wallets;
@@ -18,14 +18,14 @@ public partial interface IWalletModel : INotifyPropertyChanged;
 [AutoInterface]
 public partial class WalletModel : ReactiveObject
 {
-	private readonly Lazy<IWalletCoinjoinModel> _coinjoin;
+	private readonly Lazy<IWalletCoinjoinModel?> _coinjoin;
 	private readonly Lazy<IWalletCoinsModel> _coins;
 
 	[AutoNotify] private bool _isLoggedIn;
 	[AutoNotify] private bool _isLoaded;
 	[AutoNotify] private bool _isSelected;
 
-	public WalletModel(Wallet wallet, IAmountProvider amountProvider)
+	public WalletModel(Wallet wallet,  IAmountProvider amountProvider)
 	{
 		Wallet = wallet;
 		AmountProvider = amountProvider;
@@ -34,7 +34,14 @@ public WalletModel(Wallet wallet, IAmountProvider amountProvider)
 		Loader = new WalletLoadWorkflow(Wallet);
 		Settings = new WalletSettingsModel(Wallet.KeyManager);
 
-		_coinjoin = new(() => new WalletCoinjoinModel(Wallet, Settings));
+		_coinjoin = new(() =>
+		{
+			var coinJoinManager = Services.HostedServices.GetOrDefault<CoinJoinManager>();
+			return coinJoinManager is not null
+				? new WalletCoinjoinModel(Wallet, coinJoinManager, Settings)
+				: null;
+		});
+
 		_coins = new(() => new WalletCoinsModel(wallet, this));
 
 		Transactions = new WalletTransactionsModel(this, wallet);
@@ -76,6 +83,12 @@ public WalletModel(Wallet wallet, IAmountProvider amountProvider)
 			.BindTo(this, x => x.IsLoaded);
 	}
 
+	public IObservable<bool> IsCoinjoinRunning => _coinjoin.Value?.IsRunning ?? Observable.Return(false);
+
+	public IObservable<bool> IsCoinjoinStarted => _coinjoin.Value?.IsStarted ?? Observable.Return(false);
+
+	public bool IsCoinJoinEnabled => _coinjoin.Value is not null;
+
 	public IAddressesModel Addresses { get; }
 
 	internal Wallet Wallet { get; }
@@ -104,7 +117,7 @@ public WalletModel(Wallet wallet, IAmountProvider amountProvider)
 
 	public IWalletPrivacyModel Privacy { get; }
 
-	public IWalletCoinjoinModel Coinjoin => _coinjoin.Value;
+	public IWalletCoinjoinModel? Coinjoin => _coinjoin.Value;
 
 	public IObservable<WalletState> State { get; }
 

WalletWasabi.Fluent/Models/Wallets/WalletRepository.cs

@@ -14,6 +14,7 @@
 using WalletWasabi.Helpers;
 using WalletWasabi.Hwi.Models;
 using WalletWasabi.Models;
+using WalletWasabi.WabiSabi.Client;
 using WalletWasabi.Wallets;
 
 namespace WalletWasabi.Fluent.Models.Wallets;

WalletWasabi.Fluent/ViewModels/HelpAndSupport/FindCoordinatorLinkViewModel.cs

@@ -0,0 +1,25 @@
+using System.Windows.Input;
+using ReactiveUI;
+using WalletWasabi.Fluent.ViewModels.Wallets;
+
+namespace WalletWasabi.Fluent.ViewModels.HelpAndSupport;
+
+[NavigationMetaData(
+	Title = "Find a Coordinator",
+	Caption = "Open Wasabi's documentation website",
+	Order = 3,
+	Category = "Help & Support",
+	Keywords =
+	[
+		"Find", "Coordinator", "Coinjoin", "Docs", "Documentation", "Guide"
+	],
+	IconName = "book_question_mark_regular")]
+public partial class FindCoordinatorLinkViewModel : TriggerCommandViewModel
+{
+	private FindCoordinatorLinkViewModel()
+	{
+		TargetCommand = ReactiveCommand.CreateFromTask(async () => await UiContext.FileSystem.OpenBrowserAsync(WalletViewModel.FindCoordinatorLink));
+	}
+
+	public override ICommand TargetCommand { get; }
+}

WalletWasabi.Fluent/ViewModels/MainViewModel.cs

@@ -191,7 +191,7 @@ public void Initialize()
 	{
 		UiContext.WalletRepository.Wallets
 			.Connect()
-			.FilterOnObservable(x => x.Coinjoin.IsRunning)
+			.FilterOnObservable(x => x.IsCoinjoinRunning)
 			.ToCollection()
 			.Select(x => x.Count != 0)
 			.BindTo(this, x => x.IsCoinJoinActive);

WalletWasabi.Fluent/ViewModels/MainViewModelExtensions.cs

@@ -46,6 +46,7 @@ public static void RegisterAllViewModels(this MainViewModel mainViewModel, UiCon
 		BugReportLinkViewModel.RegisterLazy(() => new BugReportLinkViewModel(uiContext));
 		DocsLinkViewModel.RegisterLazy(() => new DocsLinkViewModel(uiContext));
 		OpenDataFolderViewModel.RegisterLazy(() => new OpenDataFolderViewModel(uiContext));
+		FindCoordinatorLinkViewModel.RegisterLazy(() => new FindCoordinatorLinkViewModel(uiContext));
 		OpenWalletsFolderViewModel.RegisterLazy(() => new OpenWalletsFolderViewModel(uiContext));
 		OpenLogsViewModel.RegisterLazy(() => new OpenLogsViewModel(uiContext));
 		OpenTorLogsViewModel.RegisterLazy(() => new OpenTorLogsViewModel(uiContext));

WalletWasabi.Fluent/ViewModels/Wallets/CoinJoinStateViewModel.cs

@@ -10,6 +10,7 @@
 using WalletWasabi.Fluent.State;
 using WalletWasabi.Fluent.ViewModels.Wallets.Settings;
 using WalletWasabi.WabiSabi.Backend.Rounds;
+using WalletWasabi.WabiSabi.Client;
 using WalletWasabi.WabiSabi.Client.CoinJoinProgressEvents;
 using WalletWasabi.WabiSabi.Client.StatusChangedEvents;
 
@@ -64,16 +65,17 @@ public partial class CoinJoinStateViewModel : ViewModelBase
 	[AutoNotify] private bool _isInCriticalPhase;
 	[AutoNotify] private bool _isCountDownDelayHappening;
 	[AutoNotify] private bool _areAllCoinsPrivate;
+	[AutoNotify] private bool _isCoinjoinSupported;
 
 	private DateTimeOffset _countDownStartTime;
 	private DateTimeOffset _countDownEndTime;
 
-	public CoinJoinStateViewModel(UiContext uiContext, IWalletModel wallet, WalletSettingsViewModel settings)
+	public CoinJoinStateViewModel(UiContext uiContext, IWalletModel wallet, IWalletCoinjoinModel walletCoinjoinModel, WalletSettingsViewModel settings)
 	{
 		UiContext = uiContext;
 		_wallet = wallet;
 
-		wallet.Coinjoin.StatusUpdated
+		walletCoinjoinModel.StatusUpdated
 					   .Do(ProcessStatusChange)
 					   .Subscribe();
 
@@ -117,7 +119,7 @@ public CoinJoinStateViewModel(UiContext uiContext, IWalletModel wallet, WalletSe
 			if (wallet.Settings.IsCoinjoinProfileSelected)
 			{
 				var overridePlebStop = _stateMachine.IsInState(State.PlebStopActive);
-				await wallet.Coinjoin.StartAsync(stopWhenAllMixed: !IsAutoCoinJoinEnabled, overridePlebStop);
+				await walletCoinjoinModel.StartAsync(stopWhenAllMixed: !IsAutoCoinJoinEnabled, overridePlebStop);
 			}
 		});
 
@@ -127,7 +129,7 @@ public CoinJoinStateViewModel(UiContext uiContext, IWalletModel wallet, WalletSe
 				x => x.PauseSpreading,
 				(isInCriticalPhase, pauseSpreading) => !isInCriticalPhase && !pauseSpreading);
 
-		StopPauseCommand = ReactiveCommand.CreateFromTask(wallet.Coinjoin.StopAsync, stopPauseCommandCanExecute);
+		StopPauseCommand = ReactiveCommand.CreateFromTask(walletCoinjoinModel.StopAsync, stopPauseCommandCanExecute);
 
 		AutoCoinJoinObservable = wallet.Settings.WhenAnyValue(x => x.AutoCoinjoin);
 
@@ -148,7 +150,8 @@ public CoinJoinStateViewModel(UiContext uiContext, IWalletModel wallet, WalletSe
 		_autoCoinJoinStartTimer = new DispatcherTimer { Interval = TimeSpan.FromMinutes(Random.Shared.Next(5, 16)) };
 		_autoCoinJoinStartTimer.Tick += async (_, _) =>
 		{
-			await wallet.Coinjoin.StartAsync(stopWhenAllMixed: false, false);
+			await walletCoinjoinModel.StartAsync(stopWhenAllMixed: false, false);
+
 			_autoCoinJoinStartTimer.Stop();
 		};
 
@@ -175,6 +178,10 @@ public CoinJoinStateViewModel(UiContext uiContext, IWalletModel wallet, WalletSe
 				await mainViewModel.SettingsPage.ActivateCoordinatorTab();
 			}
 		});
+
+		CoordinatorHelpCommand = ReactiveCommand.CreateFromTask(() => UiContext.FileSystem.OpenBrowserAsync("https://www.google.com"));
+
+		IsCoinjoinSupported = _wallet.Coinjoin is not null;
 	}
 
 	private enum State
@@ -207,8 +214,6 @@ private enum Trigger
 
 	public ICommand NavigateToExcludedCoinsCommand { get; }
 
-	public ICommand NavigateToCoordinatorSettingsCommand { get; }
-
 	public bool IsAutoCoinJoinEnabled => _wallet.Settings.AutoCoinjoin;
 
 	public IObservable<bool> AutoCoinJoinObservable { get; }
@@ -220,6 +225,9 @@ private enum Trigger
 	public ICommand PlayCommand { get; }
 
 	public ICommand StopPauseCommand { get; }
+	public ICommand NavigateToCoordinatorSettingsCommand { get; }
+
+	public ICommand CoordinatorHelpCommand { get; }
 
 	private void ConfigureStateMachine()
 	{

WalletWasabi.Fluent/ViewModels/Wallets/Settings/WalletCoinJoinSettingsViewModel.cs

@@ -95,7 +95,7 @@ public WalletCoinJoinSettingsViewModel(UiContext uiContext, IWalletModel walletM
 			.ObserveOn(RxApp.TaskpoolScheduler)
 			.Subscribe(x => _wallet.Settings.OutputWalletId = x.Id);
 
-		walletModel.Coinjoin.IsStarted
+		walletModel.IsCoinjoinStarted
 			.Select(isRunning => !isRunning)
 			.BindTo(this, x => x.IsOutputWalletSelectionEnabled);