WIP - Minimal refactor with SendParameters

WalletWasabi.Fluent/Models/Transactions/PrivacySuggestionsModel.cs

@@ -20,7 +20,8 @@
 
 namespace WalletWasabi.Fluent.Models.Transactions;
 
-public class PrivacySuggestionsModel
+[AutoInterface]
+public partial class PrivacySuggestionsModel
 {
 	private const decimal MaximumDifferenceTolerance = 0.25m;
 	private const int ConsolidationTolerance = 10;
@@ -31,15 +32,16 @@ public class PrivacySuggestionsModel
 	/// <summary>Allow at most one suggestion generation run.</summary>
 	private readonly AsyncLock _asyncLock = new();
 
-	private readonly Wallet _wallet;
 	private readonly CoinJoinManager _cjManager;
-
+	private readonly SendParameters _sendParameters;
+	private readonly Wallet _wallet;
 	private CancellationTokenSource? _singleRunCancellationTokenSource;
 	private CancellationTokenSource? _linkedCancellationTokenSource;
 
-	public PrivacySuggestionsModel(Wallet wallet)
+	public PrivacySuggestionsModel(SendParameters sendParameters)
 	{
-		_wallet = wallet;
+		_sendParameters = sendParameters;
+		_wallet = sendParameters.Wallet;
 		_cjManager = Services.HostedServices.Get<CoinJoinManager>();
 	}
 
@@ -155,15 +157,17 @@ private IEnumerable<PrivacyItem> VerifyPrivacyLevel(Parameters parameters)
 			yield break;
 		}
 
+		var availableCoins = _sendParameters.AvailableCoins;
+
 		ImmutableList<SmartCoin> coinsToExclude = _cjManager.CoinsInCriticalPhase[_wallet.WalletId];
 		bool wasCoinjoiningCoinUsed = parameters.Transaction.SpentCoins.Any(coinsToExclude.Contains);
 
 		// Only exclude coins if the original transaction doesn't use them either.
-		var allPrivateCoin = _wallet.Coins.Where(x => x.GetPrivacyLevel(_wallet.AnonScoreTarget) == PrivacyLevel.Private).ToArray();
+		var allPrivateCoin = availableCoins.Where(x => x.GetPrivacyLevel(_wallet.AnonScoreTarget) == PrivacyLevel.Private).ToArray();
 
 		allPrivateCoin = wasCoinjoiningCoinUsed ? allPrivateCoin : allPrivateCoin.Except(coinsToExclude).ToArray();
 
-		var onlyKnownByTheRecipientCoins = _wallet.Coins.Where(x => parameters.TransactionInfo.Recipient.Equals(x.GetLabels(_wallet.AnonScoreTarget), StringComparer.OrdinalIgnoreCase)).ToArray();
+		var onlyKnownByTheRecipientCoins = availableCoins.Where(x => parameters.TransactionInfo.Recipient.Equals(x.GetLabels(_wallet.AnonScoreTarget), StringComparer.OrdinalIgnoreCase)).ToArray();
 		var allSemiPrivateCoin =
 			_wallet.Coins.Where(x => x.GetPrivacyLevel(_wallet.AnonScoreTarget) == PrivacyLevel.SemiPrivate)
 			.Union(onlyKnownByTheRecipientCoins)

WalletWasabi.Fluent/Models/Wallets/WalletModel.cs

@@ -5,6 +5,7 @@
 using ReactiveUI;
 using WalletWasabi.Fluent.Helpers;
 using WalletWasabi.Fluent.Infrastructure;
+using WalletWasabi.Fluent.Models.Transactions;
 using WalletWasabi.Fluent.ViewModels.Wallets.Labels;
 using WalletWasabi.Wallets;
 
@@ -121,6 +122,11 @@ public IWalletInfoModel GetWalletInfo()
 		return new WalletInfoModel(Wallet);
 	}
 
+	public IPrivacySuggestionsModel GetPrivacySuggestionsModel(SendParameters sendParameters)
+	{
+		return new PrivacySuggestionsModel(sendParameters);
+	}
+
 	public void Rename(string newWalletName)
 	{
 		Services.WalletManager.RenameWallet(Wallet, newWalletName);

WalletWasabi.Fluent/ViewModels/Wallets/Send/PrivacySuggestionsFlyoutViewModel.cs

@@ -9,13 +9,14 @@
 using System.Threading.Tasks;
 using WalletWasabi.Blockchain.TransactionBuilding;
 using WalletWasabi.Fluent.Models.Transactions;
+using WalletWasabi.Fluent.Models.Wallets;
 using WalletWasabi.Wallets;
 
 namespace WalletWasabi.Fluent.ViewModels.Wallets.Send;
 
 public partial class PrivacySuggestionsFlyoutViewModel : ViewModelBase
 {
-	private readonly PrivacySuggestionsModel _privacySuggestionsModel;
+	private readonly IPrivacySuggestionsModel _privacySuggestionsModel;
 	private readonly Subject<IEnumerable<PrivacyWarning>> _previewWarnings = new();
 
 	[AutoNotify] private PrivacySuggestion? _previewSuggestion;
@@ -27,9 +28,9 @@ public partial class PrivacySuggestionsFlyoutViewModel : ViewModelBase
 	[AutoNotify] private bool _goodPrivacy;
 	[AutoNotify] private bool _maxPrivacy;
 
-	public PrivacySuggestionsFlyoutViewModel(Wallet wallet)
+	public PrivacySuggestionsFlyoutViewModel(IWalletModel wallet)
 	{
-		_privacySuggestionsModel = new PrivacySuggestionsModel(wallet);
+		_privacySuggestionsModel = wallet.GetPrivacySuggestionsModel();
 	}
 
 	public ObservableCollection<PrivacyWarning> Warnings { get; } = new();

WalletWasabi.Fluent/ViewModels/Wallets/Send/SendViewModel.cs

@@ -162,7 +162,9 @@ private async Task OnNextAsync()
 			await coinJoinManager.WalletEnteredSendingAsync(_wallet);
 		}
 
-		Navigate().To().TransactionPreview(_wallet, _walletModel, transactionInfo);
+		var sendParameters = _parameters with { TransactionInfo = transactionInfo };
+
+		Navigate().To().TransactionPreview(_wallet, _walletModel, sendParameters);
 	}
 
 	private async Task OnAutoPasteAsync()