Extract and use real-world data in tests #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
reviewed
Nov 8, 2024
| @@ -10,7 +10,7 @@ use crate::data; | |||
| use crate::data::PropertyPath; | |||
| use crate::data::{AttributeValue, Predicate}; | |||
| use crate::service::GrpcService; | |||
| use cel_interpreter::functions::duration; | |||
| use cel_interpreter::functions::time::duration; | |||
There was a problem hiding this comment.
Ugh... yeah! Blame me for that one 😢
alexsnaps
reviewed
Nov 8, 2024
alexsnaps
reviewed
Nov 8, 2024
adam-cattermole
force-pushed
the
test-data
branch
2 times, most recently
from
fd23df0 to
c58d7ed
Compare
alexsnaps
approved these changes
Nov 8, 2024
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
adam-cattermole
force-pushed
the
test-data
branch
from
c58d7ed to
0f5c411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.scheme, therequest.timeas well as the ordering of some headers