empty predicates do apply

Signed-off-by: Eguzki Astiz Lezaun <[email protected]>

src/configuration/action.rs

@@ -26,16 +26,17 @@ impl Action {
             .compiled_predicates
             .get()
             .expect("predicates must be compiled by now");
-        predicates
-            .iter()
-            .enumerate()
-            .all(|(pos, predicate)| match predicate.test() {
-                Ok(b) => b,
-                Err(err) => {
-                    error!("Failed to evaluate {}: {}", self.predicates[pos], err);
-                    panic!("Err out of this!")
-                }
-            })
+        predicates.is_empty()
+            || predicates
+                .iter()
+                .enumerate()
+                .all(|(pos, predicate)| match predicate.test() {
+                    Ok(b) => b,
+                    Err(err) => {
+                        error!("Failed to evaluate {}: {}", self.predicates[pos], err);
+                        panic!("Err out of this!")
+                    }
+                })
     }
 
     pub fn build_descriptors(&self) -> RepeatedField<RateLimitDescriptor> {
@@ -121,3 +122,27 @@ impl Action {
         Some(res)
     }
 }
+
+#[cfg(test)]
+mod test {
+    use crate::configuration::action::Action;
+    use std::cell::OnceCell;
+
+    #[test]
+    fn empty_predicates_do_apply() {
+        let compiled_predicates = OnceCell::new();
+        compiled_predicates
+            .set(Vec::default())
+            .expect("predicates must not be compiled yet!");
+
+        let action = Action {
+            service: String::from("svc1"),
+            scope: String::from("sc1"),
+            predicates: vec![],
+            compiled_predicates,
+            data: vec![],
+        };
+
+        assert!(action.conditions_apply())
+    }
+}

src/configuration/action_set.rs

@@ -57,3 +57,24 @@ impl ActionSet {
                 })
     }
 }
+
+#[cfg(test)]
+mod test {
+    use crate::configuration::action_set::ActionSet;
+
+    fn build_action_set(name: &str) -> ActionSet {
+        ActionSet::new(name.to_owned(), Default::default(), Vec::new())
+    }
+
+    #[test]
+    fn empty_route_rule_conditions_do_apply() {
+        let action_set_1 = build_action_set("as_1");
+        action_set_1
+            .route_rule_conditions
+            .compiled_predicates
+            .set(Vec::default())
+            .expect("Predicates must not be compiled yet!");
+
+        assert!(action_set_1.conditions_apply())
+    }
+}