Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for OPA external registry #85

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Tests for OPA external registry #85

merged 1 commit into from
Sep 22, 2022

Conversation

jsmolar
Copy link

@jsmolar jsmolar commented Sep 9, 2022

No description provided.

@pehala pehala marked this pull request as draft September 9, 2022 09:58
@pehala pehala changed the title Draft: Tests for OPA external registry Tests for OPA external registry Sep 9, 2022
@jsmolar jsmolar force-pushed the opa_external branch 3 times, most recently from f390c15 to 6a92c08 Compare September 9, 2022 13:38
@jsmolar jsmolar requested review from pehala and mkudlej September 9, 2022 13:41
pehala
pehala reviewed Sep 9, 2022
View reviewed changes
testsuite/openshift/mockserver.py Outdated Show resolved Hide resolved
testsuite/tests/kuadrant/authorino/authorization/opa/conftest.py Outdated Show resolved Hide resolved
testsuite/openshift/objects/auth_config.py Outdated Show resolved Hide resolved
testsuite/tests/kuadrant/authorino/authorization/opa/conftest.py Outdated Show resolved Hide resolved
testsuite/openshift/objects/auth_config.py Outdated Show resolved Hide resolved
testsuite/openshift/objects/auth_config.py Outdated Show resolved Hide resolved
@pehala pehala marked this pull request as ready for review September 13, 2022 08:11
guicassolato
guicassolato approved these changes Sep 22, 2022
View reviewed changes
Copy link

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't pretend I understand everything how this works, but at least from the perspective of the configs, expected outputs, etc, it all looks good to me.

@pehala pehala merged commit c6074ba into Kuadrant:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakurban jakurban jakurban approved these changes

@pehala pehala pehala approved these changes

@guicassolato guicassolato guicassolato approved these changes

@mkudlej mkudlej Awaiting requested review from mkudlej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsmolar @guicassolato @pehala @jakurban