Added identical hostnames test for AuthPolicy #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trepel
force-pushed
the
identical-hostname-auth-tests
branch
2 times, most recently
from
cd961de to
6544537
Compare
pehala
reviewed
Jun 14, 2024
testsuite/tests/kuadrant/identical_hostname/test_auth_on_gw_and_route.py
Outdated
Show resolved
Hide resolved
testsuite/tests/kuadrant/identical_hostname/test_auth_on_two_routes.py
Outdated
Show resolved
Hide resolved
testsuite/tests/kuadrant/identical_hostname/test_auth_on_gw_and_route.py
Outdated
Show resolved
Hide resolved
testsuite/tests/kuadrant/identical_hostname/test_auth_on_two_routes.py
Outdated
Show resolved
Hide resolved
testsuite/tests/kuadrant/identical_hostname/test_auth_on_two_routes.py
Outdated
Show resolved
Hide resolved
testsuite/tests/kuadrant/identical_hostname/test_auth_on_two_routes.py
Outdated
Show resolved
Hide resolved
trepel
force-pushed
the
identical-hostname-auth-tests
branch
2 times, most recently
from
169e57b to
2d8f4e5
Compare
pehala
reviewed
Jun 17, 2024
testsuite/tests/kuadrant/identical_hostname/test_identical_hostnames_auth_on_gw_and_route.py
Outdated
Show resolved
Hide resolved
testsuite/tests/kuadrant/identical_hostname/test_auth_on_two_routes.py
Outdated
Show resolved
Hide resolved
trepel
force-pushed
the
identical-hostname-auth-tests
branch
from
2d8f4e5 to
cc7e5d5
Compare
pehala
reviewed
Jun 18, 2024
testsuite/tests/kuadrant/identical_hostname/test_identical_hostnames_auth_on_gw_and_route.py
Outdated
Show resolved
Hide resolved
trepel
force-pushed
the
identical-hostname-auth-tests
branch
from
cc7e5d5 to
cc7bef6
Compare
pehala
previously approved these changes
Jun 19, 2024
trepel
force-pushed
the
identical-hostname-auth-tests
branch
2 times, most recently
from
e0433e6 to
dd31403
Compare
pehala
reviewed
Jun 21, 2024
trepel
force-pushed
the
identical-hostname-auth-tests
branch
from
dd31403 to
2e036a0
Compare
pehala
approved these changes
Jun 21, 2024
jsmolar
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Partially addresses #406
It covers two scenarios, both testing current behavior
For details see https://github.com/Kuadrant/kuadrant-operator/blob/main/doc/auth.md#limitation-multiple-network-resources-with-identical-hostnames
Verification Steps
Eye review, execute both tests and make sure they pass.
Note
I will proceed with RateLimitPolicy (RLP) scenarios once this is reviewed so that I can incorporate feedback from this PR there. The 1) scenario for RLP is identical, I will think of using parametrized fixture called
policyinstead of having two identical tests one using AuthPolicy and other RLP.The 2) scenario for RLP is slightly different, not sure if it makes sense to try to use the same test for both