Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Mockserver expectation #169

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Simplify Mockserver expectation #169

merged 1 commit into from
Feb 6, 2023

Conversation

jsmolar
Copy link

@jsmolar jsmolar commented Jan 26, 2023

This PR adds some functionality and simplifies Mockserver

  • removes the unnecessary path argument for the create_expectation method. The expectation_id is used to create a path for expectation. It is possible to create expectations with scope function.
  • adds a new method that creates an expectation for templated responses: https://www.mock-server.com/mock_server/response_templates.html
  • an instance of mockserver now stores live expectations

Copy link
Contributor

@pehala pehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be happier if the new methods are added only when needed (=in the PR that requires them), but I will approve this nonetheless.

@pehala pehala merged commit 9089cab into Kuadrant:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants