Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic Limitador tests #167

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Add basic Limitador tests #167

merged 1 commit into from
Mar 27, 2023

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Jan 24, 2023

  • Simple limit test
  • Multiple iteration test

Closes #166, #165

@pehala pehala requested review from ficap and jakurban January 24, 2023 11:58
averevki
averevki reviewed Jan 26, 2023
View reviewed changes
testsuite/utils.py Outdated Show resolved Hide resolved
@pehala pehala requested review from averevki and jsmolar March 20, 2023 12:00
averevki
averevki requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@averevki averevki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run these tests without kuadrant enabled in the settings, it won't skip them but rather throw an error that Authorino (NoneType in this case) doesn't have a URL method during envoy creation. Same with the reconciliation tests.

testsuite/utils.py Outdated Show resolved Hide resolved
testsuite/openshift/objects/rate_limit.py Outdated Show resolved Hide resolved
testsuite/openshift/objects/rate_limit.py Show resolved Hide resolved
averevki
averevki previously approved these changes Mar 23, 2023
View reviewed changes
jsmolar
jsmolar reviewed Mar 23, 2023
View reviewed changes
testsuite/utils.py Outdated Show resolved Hide resolved
testsuite/tests/kuadrant/conftest.py Show resolved Hide resolved
@pehala
Add basic Limitador tests
5fbcaf9 
- Simple limit test
- Multiple iteration test
@pehala pehala merged commit 43814ee into Kuadrant:main Mar 27, 2023
pehala added a commit to pehala/testsuite that referenced this pull request Apr 11, 2023
@pehala
Merge pull request Kuadrant#167 from pehala/ratelimit
24fd4aa 
Add basic Limitador tests
@pehala pehala mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmolar jsmolar jsmolar approved these changes

@averevki averevki averevki left review comments

@ficap ficap Awaiting requested review from ficap

@jakurban jakurban Awaiting requested review from jakurban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple Rate limit tests
3 participants
@pehala @jsmolar @averevki