This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
refactor: Make more consistent with other kuadrant operators #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mikenairn
commented
Feb 22, 2024
mikenairn
commented
- Keep Makefile consistent with other operators
- Remove gateway prefix from commands and make targets
* Keep Makefile consistent with other operators * Remove gateway prefix from commands and make targets
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikenairn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mikenairn
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR is stale because it has been open for 60 days with no activity. |
|
This PR was closed because it has been inactive for 30 days since being marked as stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.