Remove unnecessary dependencies and align local setup and quickstart scripts #789
Conversation
* argocd * external-dns * redis * webhook * skupper and submariner * deploy-sample-applicationset
Updates local-setup to use the same kustomizations as the quick start scripts. Installation and configuration of hub and spoke dependencies is now consistent across both deployment paths. The only difference between quick start and local setup now is that metrics is enabled by default with local-setup and managedzones and dns providers are created using local environment files instead of environment variables.
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | Generic Private Key | 9b77983 | config/webhook-setup/control/tls/tls.key | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
|
I think it is reasonable to remove the skupper and submariner docs at this point. We don't ever test them and really if you use gateway API and use an e/w technology that either support multi-cluster service or a regular service we will be able to work with it. Changes look fine. Will run a local-setup to verify |
|
local setup completed so happy to merge |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maleck13, mikenairn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
refactor: remove unnecessary dependencies
refactor: Align local-setup and quick-start deployment paths
Updates local-setup to use the same kustomizations as the quick start scripts. Installation and configuration of hub and spoke dependencies is now consistent across both deployment paths.
The only difference between quick start and local setup now is that metrics is enabled by default with local-setup, managedzones and dns providers are created using local environment files instead of environment variables and the MGC gateway controller is not running on the hub cluster.
Note: The skupper POC docs are listed in our docs site and would need to be removed before the next release if we merge this as is. Personally i see no advantage to leaving these here.