This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Make some scripts more generic #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
adam-cattermole
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
maleck13
reviewed
Dec 14, 2023
| @@ -13,7 +13,7 @@ We will start with a hub cluster and 2 workload clusters and highlight the autom | |||
|
|
|||
| ## Initial Setup | |||
|
|
|||
| In this walkthrough, we'll deploy test echo services across multiple clusters. If you followed the [Getting Started Guide](https://docs.kuadrant.io/getting-started/), you would have already set up a `MGC_ZONE_ROOT_DOMAIN` environment variable. For this tutorial, we'll derive a host from this domain for these echo services. | |||
| In this walkthrough, we'll deploy test echo services across multiple clusters. If you followed the [Getting Started Guide](https://docs.kuadrant.io/getting-started/), you would have already set up a `KUADRANT_ZONE_ROOT_DOMAIN` environment variable. For this tutorial, we'll derive a host from this domain for these echo services. | |||
There was a problem hiding this comment.
I like this change but we will also need a commit to update them here https://github.com/Kuadrant/docs.kuadrant.io/pull/44/files
|
/hold |
|
@adam-cattermole I am going to rebase main against release-0.3 branch so want to wait until that is done before merging this change. We will pick this up in 0.4 |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adam-cattermole, maleck13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to re-use some of the functions in the quickstart script for kuadrant-operator I've tried to make them a little more generic:
dockerBinCmdoverridable by env var instead of set to mgcconfigureControlleroverridableKUADRANT_instead ofMGC_