Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Remove namespace on dnsProviderSecretRef to force same namespace as M… #713

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Dec 8, 2023

…anagedZone

Fixes #712

  • Updated types
  • Regenerated crd & bundle
  • Updated example ManagedZones
  • Added note to docs
  • Updated tests

Locally the ManagedZone and dns Secret are in the same namespace:

kubectl get managedzone,secret -n multi-cluster-gateways
NAME                                     DOMAIN NAME      ID    RECORD COUNT   NAMESERVERS   READY
managedzone.kuadrant.io/mgc-dev-mz-aws   dm.hcpapps.net

NAME                         TYPE              DATA   AGE
secret/mgc-aws-credentials   kuadrant.io/aws   3      13m

Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 8, 2023
@david-martin david-martin force-pushed the remove-dnsProviderSecretRef-namespace branch from 4abe0e9 to 56f5505 Compare December 8, 2023 11:42
@david-martin david-martin force-pushed the remove-dnsProviderSecretRef-namespace branch from 56f5505 to 37a0343 Compare December 8, 2023 11:47
@david-martin david-martin force-pushed the remove-dnsProviderSecretRef-namespace branch from 37a0343 to 75d2221 Compare December 8, 2023 11:48
@david-martin david-martin requested a review from maleck13 December 8, 2023 12:10
@maleck13
Copy link
Contributor

maleck13 commented Dec 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit f513770 into Kuadrant:main Dec 8, 2023
9 checks passed
@alexsnaps alexsnaps added this to the v0.3.0 milestone Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

remove namespace option from managedzone providerRef
3 participants