Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Separate controller deploy #648

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Separate controller deploy #648

merged 1 commit into from
Nov 9, 2023

Conversation

maleck13
Copy link
Contributor

@maleck13 maleck13 commented Nov 3, 2023 •
edited
Loading

closes #639
separates out the policy and gateway controller deployments so that they can be deployed without each other

Verification

kustomize build config/default
kustomize build config/add-on-manager
kustomize build config/policy-controller

should all complete without error

Further validation

Can use the quick start and make local-setup scripts

@openshift-ci openshift-ci bot added the approved label Nov 3, 2023
mikenairn
mikenairn reviewed Nov 8, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@mikenairn
Copy link
Member

I think this looks fine, just some questions about the naming of things, and i think we might want to consider removing all the generated labels from the resources.

@maleck13 maleck13 force-pushed the separate-controller-deploy branch from 941393f to 21961cf Compare November 9, 2023 08:45
@maleck13 maleck13 force-pushed the separate-controller-deploy branch from 77acf07 to f47b301 Compare November 9, 2023 08:51
@maleck13
Copy link
Contributor Author

maleck13 commented Nov 9, 2023

https://github.com/Kuadrant/multicluster-gateway-controller/actions/runs/6809444407/job/18515739375

@maleck13
wip allow policy controller to be deployed independantly
061b011 
give policy controller gateway perms

give policy controller secret perms

move crds

update bundle

change local-setup mgc to use new crd location

move install and uninstall to policy.make

update bundle and remove ns from add-on manager

remove xargs command

add monitors and services for policy controller

remove all extra labels

update rbac

remove branch from triggers
@maleck13 maleck13 force-pushed the separate-controller-deploy branch from f47b301 to 061b011 Compare November 9, 2023 09:16
@mikenairn
Copy link
Member

This looks fine to me.

It was annoying me that we had to deviate from normal naming in the config/policy-controller files since i would have thought specifying a different namePrefix would have been sufficient, but looks as though we would have to do something more like this for just using namePrefix to work.

We might consider changing to this later, but not essential now.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maleck13, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maleck13 maleck13 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit f452cc6 Nov 9, 2023
8 of 9 checks passed
@Ygnas Ygnas mentioned this pull request Nov 10, 2023
Merged
@mikenairn mikenairn mentioned this pull request Nov 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikenairn mikenairn mikenairn approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

separate binaries and installs for policy vs gateway controller
2 participants
@maleck13 @mikenairn