This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a strategy field to the DNSPolicy spec that determines how the policy with generate endpoints for any created DNSRecords. Two strategies are allowed, `simple` and `loadbalanced`. Simple will creates a single DNS record (A or CNAME) for each listener/hostname with all ip/hostnames as targets. LoadBalanced works as before by creating a more complex record structure with CNAMES and A records using Geo and Weighted routing strategies to achieve loadbalancing functionality. The strategy field is currently marked as immutable and it should not be chnaged after initial DNSPolicy creation.
maleck13
had a problem deploying
to
e2e-internal
October 19, 2023 10:55 — with
GitHub Actions
Failure
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maleck13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maleck13
had a problem deploying
to
e2e-internal
October 19, 2023 11:05 — with
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
October 19, 2023 13:43 — with
GitHub Actions
Failure
maleck13
force-pushed
the
switch-off-ocm
branch
from
October 19, 2023 14:38
e60f6ac
to
6eb0b9c
Compare
maleck13
had a problem deploying
to
e2e-internal
October 19, 2023 14:38 — with
GitHub Actions
Failure
… IPAddress MGC types.
mikenairn
had a problem deploying
to
e2e-internal
October 19, 2023 15:27 — with
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
October 19, 2023 15:50 — with
GitHub Actions
Failure
mikenairn
had a problem deploying
to
e2e-internal
October 19, 2023 16:00 — with
GitHub Actions
Failure
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hacky branch to get a simple policy only controller and no OCM.
Try it
ensure your env is setup as normal but set the following value
export MGC_WORKLOAD_CLUSTERS_COUNT=0
yeah its odd to use OCM_SINGLE when there is no ocm....
Run the controller locally
create the needed resources
Should end up with a simple A record based IP address and TLS in place.