Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

refactor: controller-runtime v0.16.3 #467

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Aug 31, 2023

  • Upgrades controller runtime to v0.16.3
    • This allows us to easily upgrade to gateway api v1.0.0 also which requires this controller runtime version also

Resolves: #464

@KevFan KevFan temporarily deployed to e2e-internal August 31, 2023 14:21 — with GitHub Actions Inactive
@KevFan KevFan force-pushed the controller-runtime branch from 008dc06 to f570717 Compare August 31, 2023 14:23
@KevFan KevFan temporarily deployed to e2e-internal August 31, 2023 14:24 — with GitHub Actions Inactive
@KevFan KevFan force-pushed the controller-runtime branch from f570717 to 355d207 Compare August 31, 2023 14:29
@KevFan KevFan temporarily deployed to e2e-internal August 31, 2023 14:29 — with GitHub Actions Inactive
@KevFan KevFan force-pushed the controller-runtime branch from 355d207 to 27632a6 Compare August 31, 2023 14:33
@KevFan KevFan temporarily deployed to e2e-internal August 31, 2023 14:33 — with GitHub Actions Inactive
@KevFan KevFan force-pushed the controller-runtime branch from 27632a6 to 59f8c3b Compare August 31, 2023 14:35
@KevFan KevFan temporarily deployed to e2e-internal August 31, 2023 14:35 — with GitHub Actions Inactive
@KevFan
Copy link
Contributor Author

KevFan commented Aug 31, 2023

Blocked / Kept as draft for now as we've decided to wait for MVP release before making these changes

@KevFan KevFan force-pushed the controller-runtime branch from 59f8c3b to 644a94e Compare August 31, 2023 14:52
@KevFan KevFan temporarily deployed to e2e-internal August 31, 2023 14:52 — with GitHub Actions Inactive
@KevFan KevFan force-pushed the controller-runtime branch from 644a94e to b408d0b Compare September 8, 2023 14:41
@KevFan KevFan force-pushed the controller-runtime branch from b408d0b to 874803e Compare September 8, 2023 14:47
@KevFan KevFan temporarily deployed to e2e-internal September 8, 2023 14:47 — with GitHub Actions Inactive
@KevFan KevFan temporarily deployed to e2e-internal September 11, 2023 09:32 — with GitHub Actions Inactive
@KevFan KevFan temporarily deployed to e2e-internal September 19, 2023 10:25 — with GitHub Actions Inactive
@KevFan KevFan changed the title [WIP] refactor: controller-runtime v0.16.0 [WIP] refactor: controller-runtime v0.16.1 Sep 19, 2023
@KevFan KevFan temporarily deployed to e2e-internal September 25, 2023 12:30 — with GitHub Actions Inactive
@KevFan KevFan force-pushed the controller-runtime branch from 1795a4c to 06eadcb Compare October 3, 2023 16:37
@KevFan KevFan temporarily deployed to e2e-internal October 3, 2023 16:37 — with GitHub Actions Inactive
@KevFan KevFan force-pushed the controller-runtime branch from 06eadcb to 68151e2 Compare October 24, 2023 16:17
@KevFan KevFan temporarily deployed to e2e-internal October 26, 2023 09:55 — with GitHub Actions Inactive
@KevFan KevFan force-pushed the controller-runtime branch from 68151e2 to 97fb9aa Compare October 26, 2023 10:30
@KevFan KevFan changed the title [WIP] refactor: controller-runtime v0.16.1 [WIP] refactor: controller-runtime v0.16.2 Oct 26, 2023
@KevFan KevFan force-pushed the controller-runtime branch from 97fb9aa to 454ebd4 Compare October 31, 2023 12:00
@KevFan
Copy link
Contributor Author

KevFan commented Oct 31, 2023

MVP I believe has been completed, so this is ready for review

@KevFan KevFan marked this pull request as ready for review October 31, 2023 14:36
@KevFan KevFan changed the title [WIP] refactor: controller-runtime v0.16.2 refactor: controller-runtime v0.16.2 Oct 31, 2023
@KevFan KevFan force-pushed the controller-runtime branch from 454ebd4 to 54c098e Compare November 1, 2023 09:19
@KevFan KevFan changed the title refactor: controller-runtime v0.16.2 refactor: controller-runtime v0.16.3 Nov 1, 2023
@KevFan KevFan force-pushed the controller-runtime branch from 54c098e to 57db71d Compare November 8, 2023 15:57
@KevFan KevFan added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 8, 2023
@KevFan KevFan force-pushed the controller-runtime branch from 57db71d to 1ba9e74 Compare November 8, 2023 15:59
@KevFan KevFan force-pushed the controller-runtime branch from 1ba9e74 to 0fa229f Compare November 8, 2023 16:02
@mikenairn
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevFan, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 27469a2 into Kuadrant:main Nov 8, 2023
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved dependencies Pull requests that update a dependency file enhancement New feature or request lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dep: upgrade controller-runtime
2 participants