#118: Ability to handle parameters in GatewayClass

[sergioifg94]

Description

Closes #118

Ability to get parameters from a resourced referenced in the parametersRef of the GatewayClass

Verification steps

As the parameters are currently not used, in order to verify this functionality, ensure that the adequate status condition is reconciled when the parametersRef is misconfigured.

1. Start the local development clusters

   MCTC_WORKLOAD_CLUSTERS_COUNT=1 make local-setup

2. Run the controller

   (export $(cat ./controller-config.env | xargs) && export $(cat ./aws-credentials.env | xargs) && make build-controller install run-controller)

3. Create the parameters ConfigMap

   kubectl create configmap gateway-params --from-file=params=config/samples/gatewayclass_params.json -n multi-cluster-traffic-controller-system

4. Create the GatewayClass

   apiVersion: gateway.networking.k8s.io/v1beta1
   kind: GatewayClass
   metadata:
     name: mctc-gw-istio-external-instance-per-cluster
   spec:
     controllerName: "kuadrant.io/mctc-gw-controller"
     parametersRef:
       group: ""
       kind: "ConfigMap"
       namespace: "multi-cluster-traffic-controller-system"
       name: "gateway-params"

5. Create the Gateway with .spec.gatewayClassName = mctc-gw-istio-external-instance-per-cluster

   kubectl create namespace mctc-tenant
   kubectl apply -n mctc-tenant -f gateway.yaml

6. Verify that once reconciled, the annotation is set

   kubectl get gateway/example-gateway -n mctc-tenant

   metadata:
     name: example-gateway
     annotations:
       mctc-syncer-patch/kind-mctc-workload-1: [{"op":"replace","path":"/spec/gatewayClassName","value":"istio"}] 

[maksymvavilov]

Verified GatewayClass gets InvalidParameters field

[maleck13]

We have a valid use case for the parameters in adding in the supported data plane gateway controller to use (istio)
So we could actually use the code here and create a default configmap params with the gateway controller to use. This param is set as a transform on the gateway resource

[maleck13]

couple of code comments and a suggested change to make the code do some actual work for us

[sergioifg94]

Updated the PR with the suggestions, added some unit tests and updated the verification steps to verify that the patch annotation is set from the value specified in the parameters

[maleck13]

@sergioifg94 just one question before merge. Prob worth having this params created as part of local set up so it is there and being used?

[sergioifg94]

@maleck13 I added a commit to create the params in the local-setup and the parametersRef section filled by default in the sample gateway class

[maleck13]

@sergioifg94 why are we keying it off the cluster name? The idea with the gatewayclass params is it is configuration to be applied to gateways of this class, so I would expect all gateways of this class would have the same downstream class

[maleck13]

yeah same here, I think for the downstream class, each instance would have the same class

[maleck13]

I don't think the params should be keyed of the clustername, the idea with the params is it is additional config for a given gateway class and so generic

[maleck13]

@mikenairn I see your PR depends on this one. We can probably merge this, I would just prefer the params weren't keyed against a cluster. The gatewayclass params, IMO are intended as class level configuration rather than cluster level configuration cc @sergioifg94

[sergioifg94]

I was planning on waiting until patching annotations for all clusters is supported, but we can merge this as is for now and make those changes later

[sergioifg94]

@maleck13 I just updated the PR to follow your suggestion, so the parameter is now downstreamClass and the patch is applied to all clusters

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maleck13, sergioifg94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maleck13,sergioifg94]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment